Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the installation use the notebook 5.3 nbextension conf.d installation approach #1908

Closed
jasongrout opened this issue Jan 17, 2018 · 8 comments
Labels
good first issue resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jasongrout
Copy link
Member

This would make it so that we don't have to use the post-link script in the conda package, and the pip package would not need to also do jupyter nbextension install ....

See https://github.com/jupyter-widgets/widget-ts-cookiecutter/pull/9/files for an example of how to do this.

See jupyter/notebook#3116 for the notebook PR, released in notebook 5.3.

@jasongrout
Copy link
Member Author

Another example of how to do this is widgetti/ipyvolume@415f0fb

@blink1073
Copy link
Contributor

Happy to help with this at the workshop.

@jasongrout
Copy link
Member Author

Thanks. I've been accumulating a lot of "good first issue"s particularly for people wanting to tackle things at the workshop.

@maartenbreddels
Copy link
Member

working on it :)

@maartenbreddels
Copy link
Member

or maybe I shouldn't, let me know.

@jasongrout
Copy link
Member Author

I think it's fine. We definitely have enough "good first issue"s to go around.

@jasongrout
Copy link
Member Author

(but if you have other stuff to do, and can wait a few days, you can do it with a new contributor next week and help them come up to speed...)

jasongrout added a commit that referenced this issue Jan 17, 2018
for notebook 5.3 you don't need to enable the extensions anymore, solves #1908
@jasongrout
Copy link
Member Author

Fixed in #1911

@jasongrout jasongrout modified the milestones: Patch release, 7.2 Mar 19, 2018
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

3 participants