-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the installation use the notebook 5.3 nbextension conf.d installation approach #1908
Comments
Another example of how to do this is widgetti/ipyvolume@415f0fb |
Happy to help with this at the workshop. |
Thanks. I've been accumulating a lot of "good first issue"s particularly for people wanting to tackle things at the workshop. |
working on it :) |
or maybe I shouldn't, let me know. |
I think it's fine. We definitely have enough "good first issue"s to go around. |
(but if you have other stuff to do, and can wait a few days, you can do it with a new contributor next week and help them come up to speed...) |
for notebook 5.3 you don't need to enable the extensions anymore, solves #1908
Fixed in #1911 |
This would make it so that we don't have to use the post-link script in the conda package, and the pip package would not need to also do
jupyter nbextension install ...
.See https://github.com/jupyter-widgets/widget-ts-cookiecutter/pull/9/files for an example of how to do this.
See jupyter/notebook#3116 for the notebook PR, released in notebook 5.3.
The text was updated successfully, but these errors were encountered: