Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix correct display of date-based filter conditions #531

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

ianthomas23
Copy link
Contributor

Fixes #530.

Fixes the correct display of "filter by" conditions for date-based columns selected in the filter menu. The changes are trivial, it looks like it was originally a copy-and-paste error.

Screenshot of the problem is in the associated issue, and here is one after this fix:

Screencast.from.2024-08-02.14-38-08.webm

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 10cd3e6 into jupyter-widgets:main Aug 2, 2024
2 checks passed
@ianthomas23 ianthomas23 deleted the filter-dates branch August 2, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some date column filter by conditions are displayed incorrectly
2 participants