Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for the issue of merging of nested rows #489

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

TermeHansen
Copy link

Issue number of the reported bug or feature request: #459

Describe your changes
Fix for the issue when merging row headers in nested indexes

Testing performed
Using the case from https://github.com/bloomberg/ipydatagrid/blob/0354a4d66c5c1298895026cec7d99bdb360914c1/examples/Nested%20Hierarchies.ipynb#L33

but changing top and bottom row and adding an extra element:

row_bottom_level = ["Sector 1", "Sector 1", "Sector 2", "Sector 2", "Sector 2"]
row_top_level = ["Security A", "Security B", "Security C", "Security C", "Security D"]

Current code gives:
image

Fixed code gives:
image

@TermeHansen TermeHansen force-pushed the merge_rows branch 3 times, most recently from 0509d83 to 8b67581 Compare March 19, 2024 11:51
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this!

Would you be able to add a test notebook under ui-tests-ipw8/tests/notebooks to test this?

Also you need to signoff your commits. You can signoff using git commit --signoff, this also work in combination with --amend to modify your existing commits.

@martinRenou
Copy link
Member

Thanks @TermeHansen ! If you want I can push another commit to your branch to get the CI green

@TermeHansen
Copy link
Author

@martinRenou sure, whatever gets this in 😄

@martinRenou
Copy link
Member

I'll just get your visual regression test to pass, won't touch the rest of your code, thanks!

@martinRenou martinRenou force-pushed the merge_rows branch 2 times, most recently from c338c60 to 249d260 Compare March 22, 2024 08:23
@martinRenou martinRenou merged commit 93be7a5 into jupyter-widgets:main Mar 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants