XML and Text formatting support #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add bindings to XMLFragment, XMLElement, XMLText, and XMLEvent. Allows reading and writing of XML fragments from the document, which rich text editors use heavily. Closes jupyter-server#151
Rich text editors often store their markup in attributes and embeds.
Currently trying to use apply_update in a transaction causes a deadlock, as apply_update tries to make its own new transaction but is locked out. This reuses the existing transaction, which also allows applying multiple updates in a single transaction.
Allows comparing whether objects refer to the same element in a doc. Important since every access generates a new, unique Python wrapper instance. __eq__ is based directly from the underlying rust objects' `Eq` implementation. __hash__ is based off of the `Hash` implementation of the `BranchID` of the rust objects.
Like Text, XmlText can contain embedded formatting, so make that available.
|
Thanks! |
Closed
|
That's really awesome. coverage run -m pytest tests
coverage report --show-missing --fail-under=100 |
|
Done |
ColonelThirtyTwo
force-pushed
the
xml
branch
2 times, most recently
from
541cc3b
to
29a25d2
Compare
davidbrochart
approved these changes
Oct 19, 2024
There was a problem hiding this comment.
I started adding minor comments on docstrings, but I'll merge this as-is and I will open a follow-up PR.
Thanks so much @ColonelThirtyTwo, great work!
|
Released in v0.10.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #151.
Add support for YJS XML fragment, binding to yrs
XmlFragment,XmlElement,XmlText, andXmlEvent. Also add support for[Xml]Textembeds and attributes.This should make pycrdt usable with collaborative rich text editors such as prosemirror. I am testing this with TipTap.
Also add the ability to
apply_updatein a transaction. While unrelated to the above, trying to do so without this patch will cause pycrdt to deadlock, which I found annoying and inefficient.