Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update YDocument constructor #142

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Update YDocument constructor #142

merged 1 commit into from
Feb 17, 2023

Conversation

trungleduc
Copy link
Contributor

Closes #141

@welcome
Copy link

welcome bot commented Feb 16, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

davidbrochart
davidbrochart approved these changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trungleduc.

@davidbrochart davidbrochart added enhancement New feature or request maintenance labels Feb 16, 2023
hbcarlos
hbcarlos approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@hbcarlos hbcarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @trungleduc.

@hbcarlos hbcarlos merged commit c9db1e7 into jupyter-server:main Feb 17, 2023
@welcome
Copy link

welcome bot commented Feb 17, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbrochart davidbrochart davidbrochart approved these changes

@hbcarlos hbcarlos hbcarlos approved these changes

Assignees

@trungleduc trungleduc

Labels
enhancement New feature or request maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to provide an external ydoc to YDocument
3 participants
@trungleduc @davidbrochart @hbcarlos