Ability to configure cull_idle_timeout with kernelSpec #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
This change makes good sense to me - thank you @akshaychitneni! Could you please update your branch and ensure the tests pass?
akshaychitneni
force-pushed
the
culling
branch
from
6f3803d to
34e1ead
Compare
|
Thanks @kevin-bates. Updated my branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables users to configure culling behavior per kernel by configuring the timeout using kernel spec. This would provide users flexibility to configure timeout values per kernel based on their use cases