-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more content to the FAQ #588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
docs/source/reference/faq.md
Outdated
|
||
The releaser may fail to publish a package to the `npm` in the following cases: | ||
|
||
- `npmjs.com` is down, or `npm` is encountering issues publishing new packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking whether to add a point about some other once we saw in JupyterLab:
- Wrong URLs break publishing to npm with provenance: Fix URLs in debugger-extension jupyterlab/jupyterlab#15462
- Release team missing privileges on packages removed in 4.0: Missing "jupyterlab/observables": "4.6.7" in npmjs jupyterlab/jupyterlab#15677
but I am not sure how often these pop up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong URLs break publishing to npm with provenance:
This one should normally be caught by check-release
? #539
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should normally be caught by check-release?
Yes, that's what I was thinking
Sounds good. Maybe we can then try to merge #587 first, since it touches more files? |
Fixes #584