Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to show up hover tooltip automatically #864

Merged
merged 5 commits into from
Sep 28, 2022

Conversation

yamaton
Copy link
Contributor

@yamaton yamaton commented Sep 28, 2022

[EDIT] Screenshot replacement after the config rewording.

References

#362

Code changes

  • Wait for delay period before showing a hover tooltip IF autoActivate is enabled.
  • Fix TypeError warning by taking care of types.

User-facing changes

Add 'Automatic hover' and 'Hover delay' to 'Code Hover' in Advanced Setting Editor. They are disabled by default.
Here is a screenshot:

automatic-hover-setting

Backwards-incompatible changes

None.

Chores

  • linted
  • tested
  • documented
  • changelog entry

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch yamaton/jupyterlab-lsp/add-mouseover-hover

@yamaton yamaton changed the title Add aumouseover hover Add option to show up hover tooltip automatically Sep 28, 2022
@yamaton yamaton force-pushed the add-mouseover-hover branch 2 times, most recently from 1b86783 to 2b75f6e Compare September 28, 2022 00:50
@yamaton
Copy link
Contributor Author

yamaton commented Sep 28, 2022

Sorry for the mess; realized multiple mistakes after the initial PR.

Introduce a new item 'autoHover' and 'delay' to Code Hover setting.
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@krassowski krassowski merged commit d2a7a7d into jupyter-lsp:master Sep 28, 2022
@yamaton yamaton deleted the add-mouseover-hover branch September 29, 2022 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants