Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transclusions in JupyterLab 4.0.7+ #1045

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

krassowski
Copy link
Member

References

Follow-up to jupyterlab/jupyterlab#15105

Code changes

Remove reference to upstream variable unusedDocuments; this variable was removed in JupyterLab 4.0.7 (as it should have never been there)

User-facing changes

Transclusions should work more reliably in newer lab versions

Backwards-incompatible changes

None

@krassowski krassowski added the bug Something isn't working label Feb 4, 2024
Copy link

github-actions bot commented Feb 4, 2024

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-lsp/foreing-documents-compat

@krassowski krassowski merged commit 55df564 into jupyter-lsp:main Feb 4, 2024
9 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant