Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation theme and markdown parser #540

Closed
1 task
krassowski opened this issue Feb 21, 2021 · 6 comments · Fixed by #581
Closed
1 task

Documentation theme and markdown parser #540

krassowski opened this issue Feb 21, 2021 · 6 comments · Fixed by #581
Assignees

Comments

@krassowski
Copy link
Member

krassowski commented Feb 21, 2021

Two topics to discuss:

  • should we switch to the PyData Sphinx Theme which is already used in Jupyter documentation of multiple core projects (but not JupyterLab), as well as pandas, numpy etc?
  • should we switch away from recommonmark which does not seem to receive much attention nowadays to MyST parser and MyST-NB to fix issues with Markdown parsing in documentation and get built-in variable substitution with Jinja2 syntax? A few examples of current issues:

Changelog bug fixes and features at the same level (ignoring indent):

Screenshot from 2021-02-21 16-27-00

Block quotes after code blocks are merged with preceding code block:

Screenshot from 2021-02-21 16-27-34

Screenshot from 2021-02-21 16-28-10

Code blocks malformed inside lists:

Screenshot from 2021-02-21 16-29-38

Screenshot from 2021-02-21 17-08-12

TBD:

@bollwyvl
Copy link
Collaborator

I'm +:100: on going to myst-nb and pydata-sphinx-theme. jupyter-book would be lovely, but currently has some issues in the packaging department. I also still owe us an icon/wordmark... pst sites kind of anticipate you have a wide one, but it's still tasty to have an icon (favicon, etc).

Additionally on the docs front: our architecture diagrams are getting pretty out-of-date. Updating the grpahviz wouldn't be a huge lift, but ipydrawio is basically ready to rock for these kinds of tasks, with the editable SVG format being the strongest candidate for docs, I'd think, as they look good in github diffs.

@krassowski
Copy link
Member Author

Working on it this weekend.

@bollwyvl
Copy link
Collaborator

bollwyvl commented Apr 23, 2021 via email

@chrisjsewell
Copy link

Any feedback for MyST welcome, I'd like to eventually look into writing an LSP with this package for MyST in JupyterLab 😄

@bollwyvl
Copy link
Collaborator

bollwyvl commented Apr 24, 2021 via email

@chrisjsewell
Copy link

FYI, I've already dabbled with an RST language server: https://github.com/chrisjsewell/rst-language-server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants