Skip to content

Commit

Permalink
MDL-79756 core: Update usages of core/checkbox_toggleall
Browse files Browse the repository at this point in the history
* Use appropriate selectors, variable names for target and
  toggler checkboxes and renamed method.
  • Loading branch information
junpataleta committed Jan 10, 2025
1 parent 3369da0 commit e628f1b
Show file tree
Hide file tree
Showing 40 changed files with 85 additions and 85 deletions.
2 changes: 1 addition & 1 deletion admin/amd/build/bulk_user_actions.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion admin/amd/build/bulk_user_actions.min.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions admin/amd/src/bulk_user_actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ import jQuery from 'jquery';
const Selectors = {
bulkActionsForm: 'form#user-bulk-action-form',
userReportWrapper: '[data-region="report-user-list-wrapper"]',
checkbox: 'input[type="checkbox"][data-togglegroup="report-select-all"][data-toggle="slave"]',
masterCheckbox: 'input[type="checkbox"][data-togglegroup="report-select-all"][data-toggle="master"]',
checkedRows: '[data-togglegroup="report-select-all"][data-toggle="slave"]:checked',
checkbox: 'input[type="checkbox"][data-togglegroup="report-select-all"][data-toggle="target"]',
togglerCheckbox: 'input[type="checkbox"][data-togglegroup="report-select-all"][data-toggle="toggler"]',
checkedRows: '[data-togglegroup="report-select-all"][data-toggle="target"]:checked',
};

/**
Expand Down Expand Up @@ -81,8 +81,8 @@ export const init = () => {
updateUserIds();

document.addEventListener('change', event => {
// When checkboxes are checked next to individual users or the master toggle (Select all/none).
if ((event.target.matches(Selectors.checkbox) || event.target.matches(Selectors.masterCheckbox))
// When checkboxes are checked next to individual users or the toggler toggle (Select all/none).
if ((event.target.matches(Selectors.checkbox) || event.target.matches(Selectors.togglerCheckbox))
&& userReport.contains(event.target)) {
updateUserIds();
}
Expand Down
Loading

0 comments on commit e628f1b

Please sign in to comment.