Add support for registering custom listeners #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonard84
approved these changes
Jul 9, 2021
The new `testng.listeners` configuration parameter now allows to register custom listeners as a comma-separated list of fully-qualified class names. Fixes #5.
marcphilipp
force-pushed
the
marc/5-custom-listeners
branch
from
18d9ad1 to
fb1a111
Compare
l0rinc
reviewed
Jul 9, 2021
| @@ -127,6 +127,9 @@ the output directory for reports (default: "test-output") | |||
| `testng.useDefaultListeners` (boolean):: | |||
| whether TestNG's default report generating listeners should be used (default: `false`) | |||
| + | |||
| `testng.listeners` (comma-separated list of fully-qualified class names):: | |||
| custom listeners that should be registered when executing tests (default: none) | |||
There was a problem hiding this comment.
Suggested change
| custom listeners that should be registered when executing tests (default: none) | |
| custom listeners that should be registered when executing tests (default: "") |
l0rinc
reviewed
Jul 9, 2021
| @@ -127,6 +127,9 @@ the output directory for reports (default: "test-output") | |||
| `testng.useDefaultListeners` (boolean):: | |||
| whether TestNG's default report generating listeners should be used (default: `false`) | |||
| + | |||
| `testng.listeners` (comma-separated list of fully-qualified class names):: | |||
| custom listeners that should be registered when executing tests (default: none) | |||
| + | |||
| `testng.verbose` (integer):: | |||
| TestNG's level of verbosity (default: 0) | |||
There was a problem hiding this comment.
Suggested change
| TestNG's level of verbosity (default: 0) | |
| TestNG's level of verbosity (default: `0`) |
l0rinc
reviewed
Jul 9, 2021
l0rinc
reviewed
Jul 9, 2021
| @@ -208,6 +213,18 @@ void configure(TestNG testNG, ConfigurationParameters config) { | |||
| testNG.setVerbose(config.get("testng.verbose", Integer::valueOf).orElse(0)); | |||
| testNG.setUseDefaultListeners(config.getBoolean("testng.useDefaultListeners").orElse(false)); | |||
| config.get("testng.outputDirectory").ifPresent(testNG::setOutputDirectory); | |||
| config.get("testng.listeners").ifPresent(listeners -> Arrays.stream(listeners.split(",")) // | |||
| .map(ReflectionSupport::tryToLoadClass) // | |||
There was a problem hiding this comment.
- should we trim each value (see https://github.com/junit-team/testng-engine/pull/7/files#r667045387)
- should we deduplicate or throw on duplicated?
- can we test double comma
a,,b? - can we test leading/trailing comma
a,or,b?
There was a problem hiding this comment.
In #9, I've delegating the parsing of the parameter to TestNG so I don't think we have to test these cases anymore as it now behaves consistently with how TestNG handles -listener on the command line.
l0rinc
reviewed
Jul 9, 2021
l0rinc
reviewed
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
testng.listenersconfiguration parameter now allows toregister custom listeners as a comma-separated list of fully-qualified
class names.
Fixes #5.