Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that AnnotationSupport.isAnnotated() does not find repeatable annotations #4243

Merged
merged 6 commits into from
Jan 16, 2025
Merged

Document that AnnotationSupport.isAnnotated() does not find repeatable annotations #4243

merged 6 commits into from
Jan 16, 2025
+17 −0

Conversation

YongGoose
Copy link
Contributor

@YongGoose YongGoose commented Jan 12, 2025 •
edited by sbrannen
Loading

Resolves: #4058

Overview

  • Update the Javadoc for both AnnotationSupport.isAnnotated() variants to reflect this.
  • Update the User Guide documentation for AnnotationSupport to reflect this, if applicable.
  • Update the Javadoc for AnnotatedElementContext.isAnnotated() to reflect this.

I hereby agree to the terms of the JUnit Contributor License Agreement.

sbrannen
sbrannen requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I've requested a few minor changes.

documentation/src/docs/asciidoc/user-guide/extensions.adoc Outdated Show resolved Hide resolved
documentation/src/docs/asciidoc/user-guide/extensions.adoc Outdated Show resolved Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/support/AnnotationSupport.java Outdated Show resolved Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/support/AnnotationSupport.java Outdated Show resolved Hide resolved
@YongGoose
Copy link
Contributor Author

YongGoose commented Jan 13, 2025 •
edited
Loading

@marcphilipp @sbrannen

Thank you for your comments!
They were incredibly helpful in making revisions👍🏻

@marcphilipp marcphilipp merged commit f07e3ff into junit-team:main Jan 16, 2025
15 checks passed
@marcphilipp
Copy link
Member

@YongGoose Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcphilipp marcphilipp marcphilipp approved these changes

@sbrannen sbrannen sbrannen approved these changes

Assignees
No one assigned
Labels
component: Jupiter component: Platform theme: documentation theme: extensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document that AnnotationSupport.isAnnotated() does not find repeatable annotations
3 participants
@YongGoose @marcphilipp @sbrannen