Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention maven-failsafe-plugin version to be considered in User Guide #1764

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

dpolivaev
Copy link
Contributor

@dpolivaev dpolivaev commented Feb 7, 2019

Overview

It took me some hours to understand why my integration tests run with JUnit4 provider although I configured maven surefire plugin as described in the guide. It turned out that I had to update maven-failsafe plugin version too. My pull request to the documentation reflects my learnings.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #1764 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1764      +/-   ##
============================================
- Coverage     91.72%   91.71%   -0.02%     
  Complexity     4103     4103              
============================================
  Files           350      350              
  Lines          9714     9714              
  Branches        779      779              
============================================
- Hits           8910     8909       -1     
  Misses          616      616              
- Partials        188      189       +1
Impacted Files Coverage Δ Complexity Δ
...jupiter/engine/execution/ExtensionValuesStore.java 89.7% <0%> (-1.48%) 21% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f510e82...3afe951. Read the comment docs.

@sbrannen sbrannen added this to the 5.4 GA milestone Feb 7, 2019
@sbrannen sbrannen changed the title Mention maven-failsafe-plugin version to be considered Mention maven-failsafe-plugin version to be considered in User Guide Feb 7, 2019
@sbrannen sbrannen merged commit 98b1c3c into junit-team:master Feb 7, 2019
@sbrannen
Copy link
Member

sbrannen commented Feb 7, 2019

This has been merged into master

Thanks!

sbrannen added a commit that referenced this pull request Feb 7, 2019
@sbrannen sbrannen self-assigned this Feb 7, 2019
@sbrannen
Copy link
Member

sbrannen commented Feb 7, 2019

Further refined in commit d26f14f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants