Enable error-prone static analysis checks#1266

Closed

jbduncan wants to merge 16 commits intojunit-team:masterfrom jbduncan:error-prone-investigation-4

+222-60

Commits on Mar 1, 2018

Enable error-prone static analysis checks
jbduncan
committed
Apply review feedback
jbduncan
committed
Does removing custom classpaths from error-prone tasks affect the CI?
jbduncan
committed
Classpath and source options are needed, after all
jbduncan
committed
Turn on Var and Immutable checks, and fix many reported errors
jbduncan
committed
Fix tasks so that they depend of .class results of Kotlin compiler
jbduncan
committed
Fix all remaining reported problems (and change Pattern::splitToStream usages to Array.stream(String.split(..., (0|-1)) so that we're explicit about trailing-empty-string-trimming behaviour)
jbduncan
committed
Attempt to get the Kotlin side of things working with Java 10
jbduncan
committed
Revert "Turn on Var and Immutable checks, and fix many reported errors"
jbduncan
committed
Fix variable name
jbduncan
committed
Require Java 9 to run error-prone
jbduncan
committed
Revert "Revert "Turn on Var and Immutable checks, and fix many reported errors""
jbduncan
committed
Revert "Revert "Revert "Turn on Var and Immutable checks, and fix many reported errors"""
jbduncan
committed
Turn off @var check and remove error-prone annotations, since they produce too much churn. Also fix errors that were reintroduced in recent commit reverts.
jbduncan
committed
Cleanup
jbduncan
committed
Now that Kotlin runs on JDK 10 now, remove corresponding checks (and minor cleanup)
jbduncan
committed