Relocate Maven artifact "junit-dep" to "junit"

[marcphilipp]

• The junit-dep JARs are now deployed as junit:junit into the Maven repository.
• The junit:junit-dep artifact only consists of a POM pointing to junit:junit now.

Merging this would fix #332.

[marcphilipp]

When using junit:junit-dep, Maven users will get the following warning:

[WARNING] The artifact junit:junit-dep:jar:4.11-SNAPSHOT has been relocated to junit:junit:jar:4.11-SNAPSHOT

[dsaff]

Can you line up the indentation?

[marcphilipp]

Good catch! Done, see 834dcd7.

[dsaff]

Looks like almost there. How are we going to find out if we break anyone?

[dsaff]

Merged. Thanks! Suggestions on user beta testing?

[marcphilipp]

Locally, I created two sample projects, one referencing junit:junit, one referencing junit:junit-dep.

When referencing junit:junit-dep, I got a warning, as stated in my previous comment. Instead, junit:junit was referenced as a dependency which will behave exactly as junit:junit-dep before.

The sample project referencing junit:junit was also fine. I was able to include a newer Hamcrest release by excluding the dependency to hamcrest-core and instead referencing the newer hamcrest version explicity.

For existing real world usage, there are two possible scenarios:

1. People just use junit:junit which used to include the hamcrest classes and reference hamcrest-core.
2. People use junit:junit and reference a newer version of hamcrest.

For (1), there shouldn't be a problem at all. In the case of (2), it was just pure luck (i.e. correct order on classpath) that this worked before this change, it can only get better now.

[dsaff]

Great, thanks!

[marcphilipp]

Regarding beta testing: There were plenty of people interested in this issue over at #332. Thus, I would suggest that I push a snapshot release of the current master and we ask them to test it. Hopefully, we'll get some feedback... what do you think? ;-)

[dsaff]

Sounds good to me, thanks!

[eugenp]

So, on the previosuly reported:
[WARNING] The artifact junit:junit-dep:jar:4.11-SNAPSHOT has been relocated to junit:junit:jar:4.11-SNAPSHOT
Should I still see this when using junit-dep-4.11?
Thanks.

[marcphilipp]

@eugenp Yes, you should. Why do you ask?

[eugenp]

I was still getting the message and I wasn't sure if this was fixed or not.
Thanks.
Eugen.