Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid multiple syntax enable during Vim startup #419

Merged
merged 1 commit into from
Feb 21, 2016
Merged

Avoid multiple syntax enable during Vim startup #419

merged 1 commit into from
Feb 21, 2016

Conversation

itspriddle
Copy link
Contributor

If one runs vim +PlugUpdate there are two calls to syntax enable; one from plug#end() in your vimrc and another from the PlugUpdate command itself. It seems that when you use +PlugUpdate via the CLI that both calls to plug#end() happen while has('vim_starting') is true. This causes a minor issue where syntax highlighting (for the plug.vim itself) is lost when PlugUpdate finishes running.

There is a gif I found in an unrelated issue that shows this in action.

With this patch syntax highlighting is not lost when PlugUpdate finishes.

@junegunn
Copy link
Owner

Looks good, thanks. Can you update the failing assertion as well? You can run the whole test with test/run script.

@itspriddle
Copy link
Contributor Author

Yep, should be good. Let me know if not, I havent used vader before 😄

junegunn added a commit that referenced this pull request Feb 21, 2016
Avoid multiple `syntax enable` during Vim startup
@junegunn junegunn merged commit a88753e into junegunn:master Feb 21, 2016
@junegunn
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants