Add option to force 24 bit colors #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junegunn
requested changes
Jul 29, 2022
Co-authored-by: Junegunn Choi <[email protected]>
Use existing option name Co-authored-by: Junegunn Choi <[email protected]>
|
Those changes have been added and I have confirmed that the branch still works as expected. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option
g:fzf_force_24_bit_colorswhich would allow windows vim users to force the use of 24 bit colours. Currently there is a condition ins:get_colorswhich prevents this from happening, and the issue here junegunn/fzf.vim#1152 on fzf.vim seems to indicate a change has not been made because it breaks compatibility withcmd.exe. This would allow users to just force 24 bit colours to get around the poor contrast issues that occur when fzf falls back onto 256 ANSI colors.