Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vim] Encode list source to codepage #1794

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

janlazo
Copy link
Contributor

@janlazo janlazo commented Dec 16, 2019

Followup on f68017d#commitcomment-36437403

After this, all fzf.vim commands must be updated to not use truecolor formatting on Windows. Need more testing to verify if iconv is really needed. Maybe it's required for (g)vim only.

@junegunn
Copy link
Owner

junegunn commented Dec 16, 2019

Thanks again.

fzf.vim commands must be updated to not use truecolor formatting on Windows

So you mean we need an equivalent change to aa0e10e in s:get_color of fzf.vim?

@janlazo
Copy link
Contributor Author

janlazo commented Dec 16, 2019

fzf.vim commands must be updated to not use truecolor formatting on Windows

So you mean we need an equivalent change to aa0e10e in s:get_color of fzf.vim?

Yes. This restriction can be loosened for ConEmu and other Windows terminals that support truecolor after #1341 is merged.

@junegunn junegunn merged commit 5da8bbf into junegunn:master Dec 16, 2019
@junegunn
Copy link
Owner

Thanks, do you think #1341 is ready for merge?

@janlazo janlazo deleted the writefile-iconv branch December 16, 2019 06:36
@janlazo
Copy link
Contributor Author

janlazo commented Dec 18, 2019

Thanks, do you think #1341 is ready for merge?

Yes for --height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants