Don't drop buffered input data in findOffset() #1392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when
fzf
takes a while to startup, I start typing but my input gets dropped once the UI actually renders, and it's slightly annoying. It's rare (becausefzf
is usually quick), but noticeable particularly on first run after booting.To reproduce, you can simulate a slow load with:
Currently anything you type in the first second will be dropped, with this change it gets consumed as search input once fzf loads.
I don't know if it's a bit weird to modify
r.buffer
duringfindOffsets()
. It could alternatively return(skipped, row, col)
and leave it up to the caller to addskipped
tor.buffer
, but that might get awkward.I also don't know if this is the only place which needs this fix - is there a dark TUI as well as a light one?