-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide search interface in --phony mode #2890
Comments
Related: #2159 So the thing is, I added |
Fair enough. And sorry for missing the existing issue. Will try the The problem is that the zombie search box makes the feature feel incomplete. If non-searchability is really out of scope, then maybe it would be more coherent to just revert the whole feature. Anyway, it's your project. Go ahead and mark this as |
The option has valid use cases as shown above; search functionality is delegated to an external process started by And there are creative use cases like this: printf 'Definition\nSynonym\nAntonym' |
fzf --reverse --disabled --preview 'if [ -n {q} ]; then echo {} of {q}: ...; else echo Type in a word; fi'
True, especially when the user is not aware of such use cases. But we can't just change the way it works now. I'm going to leave this open and see if we can think of a nice idea to improve it. |
Got round to trying Maybe time to rename your project FYI I'm using it as a very simple CRUD file manager. Having to go thru the Enter key for everything is a deal-breaker. |
@Friptick, you could hide it a bit by adding With Adding |
Ugh, all so hacky! 😆 Except maybe the second More seriously: nice suggestions, thanks. In this case BTW I decided in the end to to drop |
Yeah, "creative solutions" is kind of my speciality! 😅 In my specific case |
Close #2890 I can't think of many use cases. Maybe for really simple menus? You can' type in queries in this mode, and the only way to trigger an fzf search is to use `search(...)` action.
See #4210. Thoughts? I'm not quite convinced if we should really have it. |
man fzf
)Info
Problem / Steps to reproduce
In
--phony
mode, "fzf becomes a simple selector interface" (says manual). The search prompt becomes useless, but it still accepts text. A bit confusing and ugly.The hack of
--bind='change:clear-query'
helps a bit but the surely the best UX is just to disable and hide the whole line when in--phony
mode?Thanks for considering, and for your work on this amazing tool.
Version 0.20.0 Ubuntu LTS
The text was updated successfully, but these errors were encountered: