Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scatter chart component #29

Merged
merged 10 commits into from
May 17, 2024
Merged

Scatter chart component #29

merged 10 commits into from
May 17, 2024

Conversation

pyyding
Copy link
Contributor

@pyyding pyyding commented May 6, 2024

Scatter chart component

WIP

  • revert tooltip changes and create a composable tooltip
  • agree on what to do with disabled tooltip animations
  • agree on where to put shared constants

other thoughts

  • maybe should re-arrange chart stuff to a separate components/chart dir and organize component exports inside it's index files-s
// folder tree:
- components/
-- main.ts
-- ReferenceLine/
----/ ReferenceLine.tsx
--- / index.ts
--- / constants.ts

// ReferenceLine/index.ts would look like:
  export * from './constants'
  export { ReferenceLine } from './ReferenceLine'

// main.ts:
export * from './chart/ReferenceLine'
export * from './chart/ChartTooltip'

@pyyding pyyding changed the title scatter chart Scatter chart component May 7, 2024
@pyyding pyyding force-pushed the kp-scatter-chart branch from 4c28d20 to 143888c Compare May 9, 2024 05:09
Copy link
Member

@ferrucc-io ferrucc-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one this one almost looks ready to go 🔥

@pyyding pyyding force-pushed the kp-scatter-chart branch from 7539949 to 5439175 Compare May 17, 2024 13:21
@pyyding pyyding requested a review from ferrucc-io May 17, 2024 13:27
@ferrucc-io ferrucc-io merged commit f4651e0 into juneHQ:main May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants