Fixed: Fixed the issue that switch tab twince #1624
Conversation
| } else { | ||
| mittBus.emit('alt-shift-right'); | ||
| } | ||
|
|
||
| break; | ||
| case 'ArrowLeft': | ||
| if (lunaId && origin) { | ||
| sendEventToLuna('KEYEVENT', 'alt+shift+left', lunaId, origin); | ||
| debouncedSwitchTab(lunaId, origin, 'ArrowLeft'); | ||
| } else { | ||
| mittBus.emit('alt-shift-left'); | ||
| } |
There was a problem hiding this comment.
There are several issues in this code related to the handling of custom keys:
-
The
debouncedSwitchTabfunction is used without being defined before it uses this context. -
The variable name "origin" in both cases should be consistent and not change between methods.
-
There's no logic implemented in the event handler that sends messages to Luna UI based on user actions like arrow movements.
-
In terms of optimizations, using TypeScript or static type checking could help catch logical mistakes at compile time.
-
It would also benefit to add error checks inside functions to ensure things don't blow up (for instance, by sending events with invalid arguments).
-
Consider reorganizing these pieces into a more reusable way so they can apply to different contexts rather than repeating logic within every method.
|
Fixed: Fixed the issue that switch tab twince