-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Julia 0.7 #100
Julia 0.7 #100
Conversation
Model.options has become an iterator over pairs: (:kwrd=>val)
import explicitly every function extended in MPBWrapper.jl
deps/build.jl
Outdated
@@ -2,13 +2,16 @@ using BinDeps | |||
|
|||
@BinDeps.setup | |||
|
|||
blasvendor = Base.BLAS.vendor() | |||
using Libdl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need Compat for Libdl, LinearAlgebra, and Sys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, but to be honest I don't know what to do with NamedTuples
, as on 0.6
we get
julia> (x=1,)
ERROR: syntax: assignment not allowed inside tuple
after reading the very long discussion in JuliaLang/julia#22194 I am not sure if NamedTuples will be ever supported by Compat... Any idea how to support both 0.6 and 0.7? |
What's the situation where you need to use NamedTuples? We haven't had an issue with this for other solvers. |
hmm I manipulate Maybe there is a better way? |
You can define an if VERSION >= v"0.7-"
addoption!(options, name, value) = ...
else
addoption!(options, name, value) = ...
end If the 0.7 version doesn't parse on 0.6, you can wrap it in ECOS is passing on nightly travis. |
src/types.jl
Outdated
@@ -68,7 +68,7 @@ struct SCSData | |||
stgs::Ptr{SCSSettings} | |||
end | |||
|
|||
struct SCSSolution | |||
@compat struct SCSSolution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This @compat
shouldn't be needed.
LGTM, thanks! |
this is an almost automatic port to
julia-0.7
; The only notable change is howkwargs
are handled (asNamedTuple
)