-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large refactor #130
Merged
Large refactor #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
==========================================
+ Coverage 94.40% 95.41% +1.01%
==========================================
Files 4 4
Lines 893 1025 +132
==========================================
+ Hits 843 978 +135
+ Misses 50 47 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
The PR does not change the benchmarks variables on a MOIU.Model.
247.500 μs (47 allocations: 815.03 KiB)
variables on a POI.Optimizer.
366.600 μs (120 allocations: 1.12 MiB)
parameters on a POI.Optimizer.
223.500 μs (107 allocations: 896.36 KiB)
parameters and variables on a POI.Optimizer.
280.100 μs (135 allocations: 805.61 KiB)
alternating parameters and variables on a POI.Optimizer.
282.600 μs (128 allocations: 649.20 KiB)
SAF constraint with variables on a MOIU.Model.
2.967 ms (659 allocations: 31.33 MiB)
SAF constraint with variables on a POI.Optimizer.
3.649 ms (732 allocations: 31.66 MiB)
SAF constraint with variables and parameters on a POI.Optimizer.
6.957 ms (2580 allocations: 61.86 MiB)
SQF constraint with variables on a MOIU.Model{Float64}.
4.811 ms (859 allocations: 46.60 MiB)
SQF constraint with variables on a POI.Optimizer.
5.364 ms (932 allocations: 46.93 MiB)
SQF constraint with product of variables and parameters on a POI.Optimizer.
56.528 ms (5698 allocations: 80.74 MiB)
SQF constraint with product of parameters on a POI.Optimizer.
9.825 ms (4498 allocations: 24.18 MiB)
SAF objective with variables on a MOIU.Model.
2.489 ms (547 allocations: 31.33 MiB)
SAF objective with variables on a POI.Optimizer.
4.341 ms (1320 allocations: 46.94 MiB)
SAF objective with variables and parameters on a POI.Optimizer.
6.737 ms (2235 allocations: 69.47 MiB)
SQF objective with variables on a MOIU.Model.
3.583 ms (747 allocations: 46.60 MiB)
SQF objective with variables on a POI.Optimizer.
6.274 ms (1620 allocations: 69.84 MiB)
SQF objective with product of variables and parameters on a POI.Optimizer.
33.104 ms (5553 allocations: 84.54 MiB)
SQF objective with product of parameters on a POI.Optimizer.
10.828 ms (4453 allocations: 35.62 MiB)
Update parameters in SAF constraint with variables and parameters on a POI.Optimizer.
8.513 ms (2586 allocations: 61.86 MiB)
Update parameters in SAF objective with variables and parameters on a POI.Optimizer.
18.710 ms (2436 allocations: 69.48 MiB)
Update parameters in SQF constraint with product of variables and parameters on a POI.Optimizer.
8.670 s (2506804 allocations: 37.41 GiB)
Update parameters in SQF constraint with product of parameters on a POI.Optimizer.
15.588 ms (4904 allocations: 24.24 MiB)
Update parameters in SQF objective with product of variables and parameters on a POI.Optimizer.
6.332 s (2006653 allocations: 37.40 GiB)
Update parameters in SQF objective with product of parameters on a POI.Optimizer.
26.456 ms (5055 allocations: 35.68 MiB) |
ianfiske
pushed a commit
to ianfiske/ParametricOptInterface.jl
that referenced
this pull request
Oct 12, 2023
Large refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #125