Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large refactor #130

Merged
merged 13 commits into from
Apr 17, 2023
Merged

Large refactor #130

merged 13 commits into from
Apr 17, 2023

Conversation

joaquimg
Copy link
Member

@joaquimg joaquimg commented Apr 10, 2023

close #125

@joaquimg joaquimg marked this pull request as draft April 10, 2023 05:59
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 96.20% and project coverage change: +1.01 🎉

Comparison is base (c10e85d) 94.40% compared to head (f1c4afd) 95.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   94.40%   95.41%   +1.01%     
==========================================
  Files           4        4              
  Lines         893     1025     +132     
==========================================
+ Hits          843      978     +135     
+ Misses         50       47       -3     
Impacted Files Coverage Δ
src/ParametricOptInterface.jl 91.83% <90.30%> (+1.33%) ⬆️
src/duals.jl 98.43% <97.36%> (+0.13%) ⬆️
src/utils.jl 99.30% <99.15%> (-0.70%) ⬇️
src/update_parameters.jl 100.00% <100.00%> (+1.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@joaquimg joaquimg changed the title [WIP] large refactor (not ready for review yet) Large refactor Apr 12, 2023
@joaquimg joaquimg marked this pull request as ready for review April 12, 2023 04:06
@guilhermebodin
Copy link
Collaborator

The PR does not change the benchmarks

variables on a MOIU.Model.
  247.500 μs (47 allocations: 815.03 KiB)
variables on a POI.Optimizer.
  366.600 μs (120 allocations: 1.12 MiB)
parameters on a POI.Optimizer.
  223.500 μs (107 allocations: 896.36 KiB)
parameters and variables on a POI.Optimizer.
  280.100 μs (135 allocations: 805.61 KiB)
alternating parameters and variables on a POI.Optimizer.
  282.600 μs (128 allocations: 649.20 KiB)
SAF constraint with variables on a MOIU.Model.
  2.967 ms (659 allocations: 31.33 MiB)
SAF constraint with variables on a POI.Optimizer.
  3.649 ms (732 allocations: 31.66 MiB)
SAF constraint with variables and parameters on a POI.Optimizer.
  6.957 ms (2580 allocations: 61.86 MiB)
SQF constraint with variables on a MOIU.Model{Float64}.
  4.811 ms (859 allocations: 46.60 MiB)
SQF constraint with variables on a POI.Optimizer.
  5.364 ms (932 allocations: 46.93 MiB)
SQF constraint with product of variables and parameters on a POI.Optimizer.
  56.528 ms (5698 allocations: 80.74 MiB)
SQF constraint with product of parameters on a POI.Optimizer.
  9.825 ms (4498 allocations: 24.18 MiB)
SAF objective with variables on a MOIU.Model.
  2.489 ms (547 allocations: 31.33 MiB)
SAF objective with variables on a POI.Optimizer.
  4.341 ms (1320 allocations: 46.94 MiB)
SAF objective with variables and parameters on a POI.Optimizer.
  6.737 ms (2235 allocations: 69.47 MiB)
SQF objective with variables on a MOIU.Model.
  3.583 ms (747 allocations: 46.60 MiB)
SQF objective with variables on a POI.Optimizer.
  6.274 ms (1620 allocations: 69.84 MiB)
SQF objective with product of variables and parameters on a POI.Optimizer.
  33.104 ms (5553 allocations: 84.54 MiB)
SQF objective with product of parameters on a POI.Optimizer.
  10.828 ms (4453 allocations: 35.62 MiB)
Update parameters in SAF constraint with variables and parameters on a POI.Optimizer.
  8.513 ms (2586 allocations: 61.86 MiB)
Update parameters in SAF objective with variables and parameters on a POI.Optimizer.
  18.710 ms (2436 allocations: 69.48 MiB)
Update parameters in SQF constraint with product of variables and parameters on a POI.Optimizer.
  8.670 s (2506804 allocations: 37.41 GiB)
Update parameters in SQF constraint with product of parameters on a POI.Optimizer.
  15.588 ms (4904 allocations: 24.24 MiB)
Update parameters in SQF objective with product of variables and parameters on a POI.Optimizer.
  6.332 s (2006653 allocations: 37.40 GiB)
Update parameters in SQF objective with product of parameters on a POI.Optimizer.
  26.456 ms (5055 allocations: 35.68 MiB)

@joaquimg joaquimg merged commit be2271c into master Apr 17, 2023
@odow odow deleted the jg/refact branch April 20, 2023 07:15
ianfiske pushed a commit to ianfiske/ParametricOptInterface.jl that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Adding constants to parameters in the objective
2 participants