make Callback_Data mutable
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for merging. It would be great to have a released version with this so we can start getting clean PkgEval runs (and so people's code won't crash in julia 1.5!). |
Keno
added a commit
to JuliaRegistries/General
that referenced
this pull request
May 18, 2022
On Julia 1.5+, NLOpt versions before jump-dev/NLopt.jl#142 cause silent memory corruption. Unfortunately, there are (older, unmaintained) packages in the Julia ecosystem that pin NLOpt 0.5, so they show up as random failures in PkgEval. Try to improve the situation by explicitly marking the compatibility to prevent installation of those older packages on recent Julia versions.
DilumAluthge
pushed a commit
to JuliaRegistries/General
that referenced
this pull request
May 19, 2022
On Julia 1.5+, NLOpt versions before jump-dev/NLopt.jl#142 cause silent memory corruption. Unfortunately, there are (older, unmaintained) packages in the Julia ecosystem that pin NLOpt 0.5, so they show up as random failures in PkgEval. Try to improve the situation by explicitly marking the compatibility to prevent installation of those older packages on recent Julia versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interop here depends on
Callback_Dataobjects being heap allocated with stable addresses, so they need to be mutable. I believe this should be backwards-compatible, but will be necessary in the future (JuliaLang/julia#34126).