Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for one-indexing #22

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Add support for one-indexing #22

merged 1 commit into from
Feb 3, 2021

Conversation

blegat
Copy link
Member

@blegat blegat commented Feb 1, 2021

Copying rowval can be costly so it's better to create is with the right indexing immediately.
With this PR, different indexing are allowed so that for instance SCS can use zero-based indexing as this is what is needed by the solver and DiffOpt can use one-based indexing as it allows it to to an allocation-free conversion to SparseMatrixCSC.

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #22 (54a7483) into master (e039723) will decrease coverage by 1.75%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   85.38%   83.63%   -1.76%     
==========================================
  Files           5        5              
  Lines         308      275      -33     
==========================================
- Hits          263      230      -33     
  Misses         45       45              
Impacted Files Coverage Δ
src/sparse_matrix.jl 100.00% <100.00%> (ø)
src/change_form.jl 73.97% <0.00%> (-3.14%) ⬇️
src/conic_form.jl 74.11% <0.00%> (-2.73%) ⬇️
src/matrix_input.jl 98.41% <0.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e039723...2471e47. Read the comment docs.

@blegat blegat merged commit d56c4aa into master Feb 3, 2021
@odow odow deleted the bl/indexing branch August 23, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant