Add CleverDicts as submodule to MOI.Utilities #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Codecov Report
@@ Coverage Diff @@
## master #767 +/- ##
==========================================
+ Coverage 94.34% 94.39% +0.05%
==========================================
Files 57 58 +1
Lines 6242 6303 +61
==========================================
+ Hits 5889 5950 +61
Misses 353 353
Continue to review full report at Codecov.
|
blegat
reviewed
Jun 15, 2019
blegat
reviewed
Jun 15, 2019
blegat
reviewed
Jun 15, 2019
blegat
approved these changes
Jun 15, 2019
odow
commented
Jun 16, 2019
| return MathOptInterface.VariableIndex(index) | ||
| end | ||
|
|
||
| key_to_index(key::MathOptInterface.VariableIndex) = key.value |
There was a problem hiding this comment.
@blegat: I've implemented the methods to use CleverDict with MOI.VariableIndex since it would be type-piracy for solvers to implement the methods. Any ideas for better places to put them? Or is here okay?
There was a problem hiding this comment.
No this seams appropriate. We it would make even more sense if we add const CleverVariableDict{V} = CleverDict{MOI.VariableIndex, V}
2 tasks
mlubin
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally conceived and implemented here: jump-dev/Gurobi.jl#216