caching bridge optimizer copy improvement #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndinsmore
changed the title
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
==========================================
+ Coverage 95.23% 95.24% +<.01%
==========================================
Files 53 53
Lines 5546 5555 +9
==========================================
+ Hits 5282 5291 +9
Misses 264 264
Continue to review full report at Codecov.
|
blegat
reviewed
Mar 12, 2019
blegat
reviewed
Mar 12, 2019
blegat
reviewed
Mar 13, 2019
blegat
reviewed
Mar 13, 2019
blegat
approved these changes
Mar 13, 2019
This was referenced Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull creates a new
add_constraintsmethod for bridge optimizers than uses itcopyconstraints!. The end result is a significant model creation improvement for Clp. Benchmarks to follow.The associated PRs are:
jump-dev/Clp.jl#57
JuliaOpt/LinQuadOptInterface.jl#96
The benchmarking results for Clp show a 40x improvement in the time it takes to copy large models from the cache to the solver:
jump-dev/Clp.jl#57 (comment)