Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for min(x, y) and max(x, y) #42

Merged
merged 2 commits into from
Sep 16, 2023
Merged

Add tests for min(x, y) and max(x, y) #42

merged 2 commits into from
Sep 16, 2023

Conversation

odow
Copy link
Member

@odow odow commented Sep 15, 2023

Closes #39

@odow odow requested a review from ccoffrin September 15, 2023 02:43
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07% 🎉

Comparison is base (a85f1a5) 95.64% compared to head (b498c1b) 95.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   95.64%   95.71%   +0.07%     
==========================================
  Files         180      184       +4     
  Lines        2042     2078      +36     
==========================================
+ Hits         1953     1989      +36     
  Misses         89       89              
Files Changed Coverage Δ
src/nlp-expr/009_010.jl 100.00% <100.00%> (ø)
src/nlp-expr/009_011.jl 100.00% <100.00%> (ø)
src/nlp/009_010.jl 100.00% <100.00%> (ø)
src/nlp/009_011.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ccoffrin
Copy link
Collaborator

I like the test. Is support for min/max only in the new NL interface? Should these be added in the @nl tests as well?

@odow
Copy link
Member Author

odow commented Sep 15, 2023

There should be support for the old interface. But I didn't add tests because I figured we'll deprecate it at some point. I can add though

Copy link
Collaborator

@ccoffrin ccoffrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odow odow merged commit af2232f into master Sep 16, 2023
4 checks passed
@odow odow deleted the od/min-max branch September 16, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add min/max operators
2 participants