nlp-mi without objective #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks reasonable to me, naming convention is consistent as I recall. @odow look good to you? |
|
@Wikunia, it is curious that this test passes with Juniper v0.6.3, before the bug fix was in place. Was it a case that only occured when using the FP? |
|
Yes it only occurs with feasibility pump. Didn't want to change the test cases here to include cbc. |
|
I figured as much, I think this PR is good then. |
odow
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from lanl-ansi/Juniper.jl#195
Seems like there was only one test case without an objective. This one adds another one which has an unbounded variable as well as a discrete and a bounded one. Juniper had problems in the feasibility pump if there was no objective but not all variables were discrete.
BTW I have not understood the naming scheme of the files. I tried to fit in but maybe I failed.
@ccoffrin you might wanna have a look.