Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relax_with_penalty #3140

Merged
merged 10 commits into from
Dec 19, 2022
Merged

Add relax_with_penalty #3140

merged 10 commits into from
Dec 19, 2022

Conversation

odow
Copy link
Member

@odow odow commented Dec 2, 2022

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 97.69% // Head: 97.69% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (2d60da9) compared to base (856dcc6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3140   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files          33       33           
  Lines        4460     4468    +8     
=======================================
+ Hits         4357     4365    +8     
  Misses        103      103           
Impacted Files Coverage Δ
src/constraints.jl 96.49% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blegat
Copy link
Member

blegat commented Dec 2, 2022

According to the JuMP style guide:

Omit ! when the name itself makes it clear that modification is taking place, e.g., add_constraint and set_name

I don't think that we are in the case where "the name itself makes it clear that modification is taking place"

@odow
Copy link
Member Author

odow commented Dec 4, 2022

Updated to penalty_relaxation!

@odow odow changed the title Add penalty_relaxation function Add penalty_relaxation! function Dec 5, 2022
@odow
Copy link
Member Author

odow commented Dec 5, 2022

Bike-shedding, how about one of:

  • make_penalty_relaxation(model)

  • create_penalty_relaxation(model)

  • add_penalty_relaxation(model)

  • reformulate_as_penalty_relaxation(model)

  • modify_model_for_penalty_relaxation(model)

  • relax_with_penalty(model)

  • relax_with_penalty!(model)

@odow odow force-pushed the od/penalty-relaxation branch from b557a40 to dbeb94f Compare December 8, 2022 22:26
@odow
Copy link
Member Author

odow commented Dec 8, 2022

Following today's call, I've renamed to relax_with_penalty!.

@odow odow changed the title Add penalty_relaxation! function Add relax_with_penalty Dec 9, 2022
@odow odow force-pushed the od/penalty-relaxation branch from dbeb94f to c7ee7b4 Compare December 9, 2022 02:47
@odow
Copy link
Member Author

odow commented Dec 15, 2022

I'll wait a couple more days for comments, and then I'll merge.

@odow odow merged commit 8f6081b into master Dec 19, 2022
@odow odow deleted the od/penalty-relaxation branch December 19, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Debuggability of JuMP models
2 participants