Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning and improve docs for modify-then-query #2858

Merged
merged 3 commits into from
Feb 3, 2022

Conversation

odow
Copy link
Member

@odow odow commented Jan 31, 2022

Closes #2797

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #2858 (9c264f0) into master (b7a84e5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9c264f0 differs from pull request most recent head 65780e9. Consider uploading reports for the commit 65780e9 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2858   +/-   ##
=======================================
  Coverage   94.79%   94.79%           
=======================================
  Files          44       44           
  Lines        5709     5710    +1     
=======================================
+ Hits         5412     5413    +1     
  Misses        297      297           
Impacted Files Coverage Δ
src/JuMP.jl 86.78% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7a84e5...65780e9. Read the comment docs.

@odow
Copy link
Member Author

odow commented Feb 2, 2022

Objections to merging?

@odow odow merged commit 2998920 into master Feb 3, 2022
@odow odow deleted the od/optimize-not-called branch February 3, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Remove dirty flag
2 participants