Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update done items on roadmap #2453

Merged
merged 1 commit into from
Feb 9, 2021
Merged

[docs] Update done items on roadmap #2453

merged 1 commit into from
Feb 9, 2021

Conversation

odow
Copy link
Member

@odow odow commented Feb 6, 2021

Implemented in Gurobi: jump-dev/Gurobi.jl#392
Documentation at the JuMP level already exists: https://jump.dev/JuMP.jl/stable/solutions/#Multiple-solutions

Copy link
Member

@joaquimg joaquimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #2453 (f22247b) into master (e25dd20) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2453   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files          43       43           
  Lines        4637     4637           
=======================================
  Hits         4276     4276           
  Misses        361      361           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e25dd20...f22247b. Read the comment docs.

@mlubin
Copy link
Member

mlubin commented Feb 6, 2021

I'm a bit confused about the documentation. Are all solutions returned by a solver guaranteed to be optimal? I know that some solvers can return suboptimal solutions found during the solve.

@odow
Copy link
Member Author

odow commented Feb 7, 2021

Hmm. Yeah I don't think the documentation should say an_optimal_solution. The solution in result = 1 is probably the optimal solution, and the others are sub-optimal, feasible solutions. You could figure that out by looking at the objective value?

@odow
Copy link
Member Author

odow commented Feb 9, 2021

So does this count as done now?

@odow odow merged commit 0205c98 into master Feb 9, 2021
@odow odow deleted the odow-patch-1 branch February 9, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants