Fix printing in IJuliaMode #2447
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2447 +/- ##
==========================================
+ Coverage 92.25% 92.26% +0.01%
==========================================
Files 43 43
Lines 4634 4642 +8
==========================================
+ Hits 4275 4283 +8
Misses 359 359
Continue to review full report at Codecov.
|
| @@ -201,7 +201,7 @@ end | |||
| function model_string(print_mode, model::AbstractModel) | |||
| ijl = print_mode == IJuliaMode | |||
| sep = ijl ? " & " : " " | |||
| eol = ijl ? "\\\\\n" : "\n" | |||
| eol = ijl ? "\\\\" : "\n" | |||
There was a problem hiding this comment.
Is this due to a bug in Documenter that is reported somewhere or a known limitation ?
There was a problem hiding this comment.
It was the same error as this: JuliaDocs/Documenter.jl#1387.
Looking through your PR, I guess the regex needs a suffix "s so it can match multiline strings:
https://github.com/JuliaDocs/Documenter.jl/pull/1426/files#diff-c34d581afcb6837fd39a6b0b0428090c049d7dad13de417d96dc08a0ed01cf70R1751-R1752
There was a problem hiding this comment.
There was a problem hiding this comment.
So the newline issue can be fixed upstream, but there is still the issue that we are using alignat instead of aligned. With this PR, the tutorials print nicely.
A few printing changes that were needed to fix the printing issues in the tutorials: #2444 (comment)
Fixes some of the points in #2446
\n. Makes no difference to latex, but Documenter struggled to print these.\\begin{alignat*}{1}becomes\\begin{aligned}x binarybecomesx ∈ {0, 1}x integerbecomesx ∈ Z\text{}instead of math.I'll post before/after screenshots from IJulia in a bit.
Before
After