-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow querying conflicts from within JuMP #2300
Conversation
Also with a simple test for the only error case. MOI dependency bumped to 0.9.14, as it's the first version supporting conflicts.
docs/src/solutions.md
Outdated
@@ -289,6 +311,7 @@ JuMP.dual | |||
JuMP.solve_time | |||
OptimizeNotCalled | |||
MOI.optimize! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this should be JuMP.optimize!
Also remove it from solvers.md to avoid a warning when generating docs.
I tried many things to make Documenter work with the new function, I can't understand what causes the problem(s) and Documenter's output is very far from useful. I'm giving up. |
I'll take a look |
Thanks! If you can find the root cause, I'm interested! |
@odow: did you have the opportunity to have a look at this? (Supposing you're not on holidays :)!) |
Yes, you just need to merge this: dourouc05#1 |
Fix doctests
Sorry, I didn't see that. It's now merged, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #2300 +/- ##
==========================================
- Coverage 91.33% 91.31% -0.03%
==========================================
Files 42 42
Lines 4258 4258
==========================================
- Hits 3889 3888 -1
- Misses 369 370 +1
Continue to review full report at Codecov.
|
This is just to ease access to the conflict machinery in MOI, including documentation. Follows #1035.
By the way, in
docs/src/solutions.md
, on line 291 (313 after this PR), the docs forMOI.optimize!
are called: shouldn't that beJuMP.optimize!
?