Refactor test/operator.jl into functions as opposed to nested testsets #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks suggest a 40% reduction in runtime, but this is still almost all compile time. Runing Julia with -O0 gives another 30% reduction.
Codecov Report
@@ Coverage Diff @@
## master #2285 +/- ##
==========================================
- Coverage 91.25% 91.23% -0.03%
==========================================
Files 42 42
Lines 4233 4234 +1
==========================================
Hits 3863 3863
- Misses 370 371 +1
Continue to review full report at Codecov.
|
mlubin
approved these changes
Jul 16, 2020
blegat
reviewed
Jul 16, 2020
blegat
approved these changes
Jul 16, 2020
|
Travis ran and passed, not sure why it isn't showing: https://travis-ci.org/github/jump-dev/JuMP.jl/builds/708773094. Coverage looks spurious. |
|
Nice! This is why #1745 is quick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks suggest a 40% reduction in runtime (for this file), but this is still almost
all compile time. Runing Julia with -O0 gives another 30% reduction.
Most of the speedup comes from not evaluating each expression twice outside the macros in the
test_expression_with_stringutility macro.Extracted from #2277