Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks and tests for NaN in constraints #2272

Merged
merged 1 commit into from
Jul 11, 2020
Merged

Add checks and tests for NaN in constraints #2272

merged 1 commit into from
Jul 11, 2020

Conversation

odow
Copy link
Member

@odow odow commented Jul 11, 2020

Closes #2233

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #2272 into master will decrease coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2272      +/-   ##
==========================================
- Coverage   91.41%   91.13%   -0.28%     
==========================================
  Files          42       42              
  Lines        4193     4196       +3     
==========================================
- Hits         3833     3824       -9     
- Misses        360      372      +12     
Impacted Files Coverage Δ
src/aff_expr.jl 88.02% <100.00%> (+0.17%) ⬆️
src/macros.jl 93.11% <100.00%> (+0.03%) ⬆️
src/Containers/vectorized_product_iterator.jl 35.71% <0.00%> (-7.15%) ⬇️
src/mutable_arithmetics.jl 85.71% <0.00%> (-6.35%) ⬇️
src/Containers/SparseAxisArray.jl 74.64% <0.00%> (-4.52%) ⬇️
src/copy.jl 88.00% <0.00%> (-4.00%) ⬇️
src/Containers/DenseAxisArray.jl 85.29% <0.00%> (-1.97%) ⬇️
src/operators.jl 87.67% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29f64d8...921969b. Read the comment docs.

@odow odow merged commit 42668d1 into master Jul 11, 2020
@odow odow deleted the od/nan_in_expr branch July 11, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add a check that constraint RHSs are finite
2 participants