Track nonlinear resultant vars outside of MOI #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #590 +/- ##
==========================================
+ Coverage 92.16% 92.24% +0.07%
==========================================
Files 6 6
Lines 2630 2642 +12
==========================================
+ Hits 2424 2437 +13
+ Misses 206 205 -1 ☔ View full report in Codecov by Sentry. |
|
This resolves all the tests to do with querying user-visible variables. |
odow
reviewed
Nov 27, 2024
| r"^test_nonlinear_expression_hs109$", | ||
| r"^test_nonlinear_expression_hs110$", | ||
| # MOI.get(MOI.ObjectiveValue()) fails for NL objectives |
There was a problem hiding this comment.
I'll take a look at this. It's probably on our end.
Keep the coverage gods happy
|
I'm happy if @torressa is happy |
torressa
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #587: instead of filtering out the NL resultant variables when querying through MOI, don't add these variables to MOI at all so they don't show up in model queries.
_update_if_necessary, the same index tracking trick applied to each entry in model.variable_info is applied to NL constraints as well, so that their resvar indices are appropriately adjusted following deletion of another variable.