-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix error due to adding null callback #448
Conversation
@simonbowly any chance you could take a look at our license? I tried generating a new API key, but it's still tied to the expired license. |
@odow sorry about that, I just updated the license. Should be valid now but you might need to generate the API key again. I'll follow up to see why the duration is so short. |
That seems to have fixed it.
Yes. Having a 2 week expiry isn't ideal... |
@chriscoey I excluded some new tests from MOI about infeasibility certificates which you can ignore. But the heuristic callback test failing seems related? |
the heuristic callback test failing seems unrelated to this PR, but I pushed a fix for it here |
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 54.57% 56.07% +1.50%
==========================================
Files 9 9
Lines 3782 3916 +134
==========================================
+ Hits 2064 2196 +132
- Misses 1718 1720 +2
Continue to review full report at Codecov.
|
replaces #447 (CI would not run on PR from fork)
fixes #395