Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error due to adding null callback #448

Merged
merged 5 commits into from
Feb 14, 2022
Merged

fix error due to adding null callback #448

merged 5 commits into from
Feb 14, 2022

Conversation

chriscoey
Copy link
Contributor

replaces #447 (CI would not run on PR from fork)
fixes #395

@odow
Copy link
Member

odow commented Feb 13, 2022

@simonbowly any chance you could take a look at our license?

image

I tried generating a new API key, but it's still tied to the expired license.

@simonbowly
Copy link
Collaborator

@odow sorry about that, I just updated the license. Should be valid now but you might need to generate the API key again.

I'll follow up to see why the duration is so short.

@odow
Copy link
Member

odow commented Feb 14, 2022

That seems to have fixed it.

I'll follow up to see why the duration is so short.

Yes. Having a 2 week expiry isn't ideal...

@odow
Copy link
Member

odow commented Feb 14, 2022

@chriscoey I excluded some new tests from MOI about infeasibility certificates which you can ignore.

But the heuristic callback test failing seems related?

@chriscoey
Copy link
Contributor Author

the heuristic callback test failing seems unrelated to this PR, but I pushed a fix for it here

test/MOI/MOI_callbacks.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #448 (16dcb75) into master (1008e8c) will increase coverage by 1.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   54.57%   56.07%   +1.50%     
==========================================
  Files           9        9              
  Lines        3782     3916     +134     
==========================================
+ Hits         2064     2196     +132     
- Misses       1718     1720       +2     
Impacted Files Coverage Δ
src/MOI_wrapper/MOI_wrapper.jl 88.50% <100.00%> (+0.27%) ⬆️
src/MOI_wrapper/MOI_callbacks.jl 97.61% <0.00%> (+0.14%) ⬆️
src/MOI_wrapper/MOI_indicator_constraint.jl 95.69% <0.00%> (+0.24%) ⬆️
src/gen95/libgrb_api.jl 25.52% <0.00%> (+8.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1008e8c...16dcb75. Read the comment docs.

@odow odow merged commit deef74e into master Feb 14, 2022
@odow odow deleted the callbacksfix branch February 14, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Undesired callback behavior
3 participants