-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failed MOI tests #434
Merged
Merged
Fix failed MOI tests #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the way to track status of objective function
…ScalarAffineFunction
odow
reviewed
Nov 12, 2021
Can you fix the format-check please? |
If the objective isn't set, getting MOI.ObjectiveFunctionType doesn't have a valid return, so it can return anything.
odow
reviewed
Nov 13, 2021
We should check whether objective is set instead of check return value of get `MOI.ObjectiveFunctionType`.
I think
The complicated thing is here. We need to check the corresponding variable of changed coefficient and set function MOI.modify(
model::Optimizer,
::MOI.ObjectiveFunction{MOI.ScalarAffineFunction{Float64}},
chg::MOI.ScalarCoefficientChange{Float64},
)
ret = GRBsetdblattrelement(
model,
"Obj",
Cint(column(model, chg.variable) - 1),
chg.new_coefficient,
)
_check_ret(model, ret)
model.is_objective_set = true
_require_update(model)
return
end |
I think this is okay for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I applied the same tricks used in Xpress.jl here to fix 3 failed MOI tests.
The
test_solve_conflict_feasible
fails because Gurobi cannot compute IIS on a feasible model