Add continuous integration #428
Conversation
|
Success |
|
Artifacts are pretty cool: https://pkgdocs.julialang.org/v1/artifacts/. They make including downloads like this trivial! |
|
Nice one! I made some progress testing the license - evidently I didn't quite configure it right, but copying in the license file from a repo secret mostly does the trick.
|
|
@simonbowly I've invited you as an admin user. That should mean you have permission to upload secrets. Let me know if that isn't the case. |
|
Cheers - I'm just testing using my own license at the moment so will wait for yours to be issued (almost sorted I think). |
|
Got the license configuration worked out - tests running ok on my master branch. Now just need to sort out your license (getting there sorry!) I had to change the artifacts usage slightly to get this running, not really sure why...
|
You probably have an existing You should have permission to push new commits to this branch, or edit the files via the web editor. (Or just make a new PR) |
|
Done - I pushed just the CI change to this PR and now see the Artifacts error at build time. "Artifacts not defined"? |
|
Oops. I was being too clever when I squashed all my test commits. Working now. Did you upload the secret? I can't see it
|
|
Nice one. I didn't yet - I was using my own license key to test on my fork. Would rather wait for the one issued specifically for JuMP if that's ok. But this should otherwise work once that is sorted. |
|
@simonbowly looks like I'll need your input on this:
Did you test a WSL on your fork? Or some other type of license? |
|
@simonbowly and I discussed the license issue offline. It's now working. However: @simonbowly when are the licenses validated? I'm seeing a lot of: |
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
=========================================
Coverage ? 61.75%
=========================================
Files ? 8
Lines ? 3300
Branches ? 0
=========================================
Hits ? 2038
Misses ? 1262
Partials ? 0 Continue to review full report at Codecov.
|
|
It only took 8.5 years, but we now have CI! That coverage is a little shoddy though. |
|
Great! Thanks for all your work on this Oscar. Re: the license checks, for WLS the license token needs to be refreshed periodically from the server. The checks might occur periodically as well as on various API calls including .update() and .optimize() so I guess in tests it occurs pretty often. It is probably not communicating with the server for every one of those messages though. |
|
Thanks for the great package! I am using Gurobi.jl in my project, and also want to conduct a continuous integration in github actions. At first, it throws then I tried to use a WSL license like what you did here, but now it throws it seems that you also encountered the same issue (#428 (comment)); how did you finally manage it? Anything I have missed? |
We use an undocumented/still-in-development feature, so for now there is probably no way for you to use Gurobi.jl in GitHub actions. If you have a commercial license, you should contact your support rep and they may be able to help you. |
|
Got it, thanks for your explanation. Also just noticed README.md wrote
|
No idea if this will work, but let's see.
cc @simonbowly