Explicit tests for MOI.TerminationStatus with infeasible statuses #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you mean to open the two PRs? I think we just need this one, correct? |
|
Actually, I meant to make two PRs with different content, but I mixed the branches locally… The other PR has minor fixes that this one doesn't have, I'll try to fix the mixup? |
This ensures that an issue like https://github.com/jump-dev/CPLEX.jl/pull/366/files doesn't sneak in.
|
The PRs should now be clearly separate. Here is a screenshot of the tests passing:
|
odow
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that an issue like https://github.com/jump-dev/CPLEX.jl/pull/366/files doesn't sneak in.
Another solution may be to move some IIS tests to MOIT, but I don't know how to test
Gurobi.ConflictStatus(or the CPLEX equivalent) in that case.