-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite C wrapper using Clang #346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtwalker
reviewed
Sep 22, 2020
Closed
Co-authored-by: Ryan Walker <[email protected]>
Same deprecation strategy as CPLEX.
|
This PR is a little hard to review, so I propose merging into |
Merging with the same plan as CPLEX: jump-dev/CPLEX.jl#316 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting this shipshape before I step back from maintaining it.
I don't know what the deprecation path is.The biggest issue is the callback file, which had some constantsCB_MIPSOL
, and some functions likecbget_xxx
. Is it worth deprecating those and nothing else?Closes #8
Closes #14
Closes #18
Closes #24
Closes #25
Closes #54
Closes #80
Closes #100
Closes #102
Closes #107
Closes #113
Closes #121
Closes #155
Closes #160
Closes #218
Closes #266
Closes #342
Closes #344
Closes #345
Closes #347