Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create utils.jl; begin testing #3

Merged
merged 3 commits into from
Jun 1, 2020
Merged

create utils.jl; begin testing #3

merged 3 commits into from
Jun 1, 2020

Conversation

akshay326
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2020

Codecov Report

Merging #3 into master will increase coverage by 100.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           master        #3        +/-   ##
=============================================
+ Coverage    0.00%   100.00%   +100.00%     
=============================================
  Files           1         1                
  Lines           1         9         +8     
=============================================
+ Hits            0         9         +9     
+ Misses          1         0         -1     
Impacted Files Coverage Δ
src/utils.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909264d...86403c9. Read the comment docs.

@akshay326
Copy link
Collaborator Author

Hey @blegat @joaquimg

Any suggestions/reviews? This is my 1st time including test cases (1st time a creating package indeed.)

Co-authored-by: Mathieu Besançon <[email protected]>
@matbesancon
Copy link
Collaborator

I added few minor suggestions, overall this is a nice first step for the structure of the project

Co-authored-by: Mathieu Besançon <[email protected]>
@akshay326
Copy link
Collaborator Author

thanks!
next thing i'm gonna do is search some good Julia lint extension 😄

@matbesancon
Copy link
Collaborator

One thing you can look at for JuMP is:
https://www.juliaopt.org/JuMP.jl/dev/style/
For general purpose: https://github.com/domluna/JuliaFormatter.jl

Copy link
Collaborator

@matbesancon matbesancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one other minor thing, I think your file can be named random_qp.jl instead of utils to have names as informative as possible

@akshay326 akshay326 merged commit d3ee3a9 into master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants