Ar/quad coefficients #213
Merged
Ar/quad coefficients #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexRobson
commented
Apr 20, 2022
test/jump.jl
Outdated
| grad_constraint = JuMP.constant(MOI.get(model, DiffOpt.BackwardOutConstraint(), ctr_le[])) | ||
| @test grad_constraint ≈ -1.0 atol=ATOL rtol=RTOL | ||
|
|
||
| # Test some overloads. Better place elsewhere? |
There was a problem hiding this comment.
Put these here as there isn't a jump.jl test file - arguably that could be created
| @@ -1,7 +1,7 @@ | |||
| name = "DiffOpt" | |||
| uuid = "930fe3bc-9c6b-11ea-2d94-6184641e85e7" | |||
| authors = ["Akshay Sharma", "Mathieu Besançon", "Joaquim Dias Garcia", "Benoît Legat"] | |||
| version = "0.3.1" | |||
| version = "0.3.2" | |||
| @@ -240,12 +240,12 @@ function JuMP.coefficient(func::MOItoJuMP, var_ref::JuMP.VariableRef) | |||
| return JuMP.coefficient(func.func, JuMP.index(var_ref)) | |||
| end | |||
| function quad_sym_half(func::MOItoJuMP, var1_ref::JuMP.VariableRef, var2_ref::JuMP.VariableRef) | |||
| check_belongs_to_model(var1_ref, func.model) | |||
| return quad_sym_half(func.func, JuMP.index(vi1), JuMP.index(var2_ref)) | |||
| check_belongs_to_model.([var1_ref, var2_ref], Ref(func.model)) | |||
There was a problem hiding this comment.
technically this change isn't being tested, but this would just test a function in JuMP so fine?
AlexRobson
force-pushed
the
ar/quad_coefficients
branch
from
f7e5c57 to
5cf665b
Compare
matbesancon
reviewed
Apr 20, 2022
matbesancon
approved these changes
Apr 20, 2022
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 89.39% 91.21% +1.81%
==========================================
Files 8 8
Lines 839 842 +3
==========================================
+ Hits 750 768 +18
+ Misses 89 74 -15
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #211