Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming #210

Merged
merged 8 commits into from
Apr 22, 2022
Merged

Renaming #210

merged 8 commits into from
Apr 22, 2022

Conversation

matbesancon
Copy link
Collaborator

Closes #208

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #210 (ecdd923) into master (db871ea) will not change coverage.
The diff coverage is 91.83%.

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   91.21%   91.21%           
=======================================
  Files           8        8           
  Lines         842      842           
=======================================
  Hits          768      768           
  Misses         74       74           
Impacted Files Coverage Δ
src/bridges.jl 100.00% <ø> (ø)
src/conic_diff.jl 93.89% <75.00%> (ø)
src/moi_wrapper.jl 85.39% <87.50%> (ø)
src/jump_moi_overloads.jl 79.81% <92.30%> (ø)
src/diff_opt.jl 99.21% <100.00%> (ø)
src/quadratic_diff.jl 97.12% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db871ea...ecdd923. Read the comment docs.

@matbesancon
Copy link
Collaborator Author

ping @blegat @joaquimg
We can bikeshed the names, it's just a global search-and-replace now
I added the former attributes in src/deprecated.jl

@matbesancon matbesancon requested a review from blegat April 19, 2022 14:21
@blegat
Copy link
Member

blegat commented Apr 19, 2022

See my comment in #208 (comment)

@matbesancon
Copy link
Collaborator Author

done in last commit

@matbesancon
Copy link
Collaborator Author

All done @blegat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Rename Backward to Reverse
2 participants