Fix getting ForwardOutVariablePrimal with JuMP v0.22 #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
- Coverage 86.08% 85.03% -1.05%
==========================================
Files 7 7
Lines 769 782 +13
==========================================
+ Hits 662 665 +3
- Misses 107 117 +10
Continue to review full report at Codecov.
|
odow
reviewed
Nov 13, 2021
| moi_func = MOI.get(JuMP.backend(model), attr, JuMP.index(con_ref)) | ||
| return JuMP.jump_function(model, moi_func) | ||
| end | ||
|
|
||
| # FIXME Workaround for https://github.com/jump-dev/JuMP.jl/issues/2797 | ||
| function _moi_get_result(model::MOI.ModelLike, args...) |
There was a problem hiding this comment.
I wanted to call it from line 39 but I forgot. It seems best to do it to keep a consistent behavior. A solution is still needed so the status shouldn't be OPTIMIZE_NOT_CALLED.
Merged
|
So this wasn't quite the fix I suggested. It now allows. you to get |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows @odow suggestion in 12/1 10:30-12:30
Closes #152