Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading DiffOpt to MOI 0.10 #150

Merged
merged 22 commits into from
Nov 12, 2021
Merged

Upgrading DiffOpt to MOI 0.10 #150

merged 22 commits into from
Nov 12, 2021

Conversation

matbesancon
Copy link
Collaborator

@matbesancon matbesancon commented Nov 11, 2021

Still a lot of errors I haven't figured out yet

  • Replace MatrixOptInterface by MOI.Utilities.MatrixOfConstraints

Closes #150

@matbesancon
Copy link
Collaborator Author

starts to tackle #150

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #150 (d9cc2e6) into master (d60c53f) will increase coverage by 0.23%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   85.84%   86.08%   +0.23%     
==========================================
  Files           6        7       +1     
  Lines         756      769      +13     
==========================================
+ Hits          649      662      +13     
  Misses        107      107              
Impacted Files Coverage Δ
src/moi_wrapper.jl 78.83% <64.70%> (+2.02%) ⬆️
src/conic_diff.jl 96.66% <93.33%> (-3.34%) ⬇️
src/diff_opt.jl 87.29% <100.00%> (-0.52%) ⬇️
src/jump_moi_overloads.jl 62.96% <100.00%> (-0.46%) ⬇️
src/product_of_sets.jl 100.00% <100.00%> (ø)
src/quadratic_diff.jl 99.12% <100.00%> (-0.01%) ⬇️
src/utils.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d60c53f...d9cc2e6. Read the comment docs.

@blegat
Copy link
Member

blegat commented Nov 11, 2021

There is an issue on Julia v1.0:

  • LazyArrays is v0.16 or earlier for Julia v1.0, these version don't support StaticArrays v1.0
  • MathOptSetDistances (MOSD) requires StaticArrays v1.0

We have 2 options: either relax the requirement in MOSD or drop support for old Julia versions.

@blegat blegat closed this Nov 11, 2021
@blegat blegat reopened this Nov 11, 2021
@matbesancon
Copy link
Collaborator Author

we should just ditch Julia 1.0 for DiffOpt, it's not directly a solver and not registered yet, 1.6 can become the new lower bound

@matbesancon
Copy link
Collaborator Author

I set julia 1.6 as the lower bound for now on this

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge, let's track the issue of the dirty flag in #152 and not keep this PR open for this.

@matbesancon matbesancon merged commit 32434d8 into master Nov 12, 2021
@matbesancon matbesancon deleted the moi-up branch November 12, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants