-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading DiffOpt to MOI 0.10 #150
Conversation
starts to tackle #150 |
Update to MOI v0.10 and JuMP v0.22
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 85.84% 86.08% +0.23%
==========================================
Files 6 7 +1
Lines 756 769 +13
==========================================
+ Hits 649 662 +13
Misses 107 107
Continue to review full report at Codecov.
|
There is an issue on Julia v1.0:
We have 2 options: either relax the requirement in MOSD or drop support for old Julia versions. |
we should just ditch Julia 1.0 for DiffOpt, it's not directly a solver and not registered yet, 1.6 can become the new lower bound |
I set julia 1.6 as the lower bound for now on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge, let's track the issue of the dirty flag in #152 and not keep this PR open for this.
Still a lot of errors I haven't figured out yet
Closes #150