Fix indexing bug in copy_to (#101)

* Fix indexing bug in copy_to * Add trailing newline * Bump version for new release
jump-dev · Oct 27, 2020 · 0f30c44 · 0f30c44 · odow · Oct 27, 2020
1 parent 9012c3f
commit 0f30c44
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "Clp"
 uuid = "e2554f3b-3117-50c0-817c-e040a3ddf72d"
 repo = "https://github.com/jump-dev/Clp.jl.git"
-version = "0.8.1"
+version = "0.8.2"
 
 [deps]
 BinaryProvider = "b99e7846-7c00-51b0-8f62-c81ae34c0232"

diff --git a/src/MOI_wrapper/MOI_wrapper.jl b/src/MOI_wrapper/MOI_wrapper.jl
@@ -311,7 +311,7 @@ function _extract_row_data(src, mapping, lb, ub, I, J, V, ::Type{S}) where S
         end
         mapping.conmap[c_index] = MOI.ConstraintIndex{
             MOI.ScalarAffineFunction{Float64}, S
-        }(length(ub))
+        }(row)
         row += 1
     end
     return

diff --git a/test/MOI_wrapper.jl b/test/MOI_wrapper.jl
@@ -126,3 +126,19 @@ end
         @test MOI.get(model, MOI.RawParameter(key)) == value
     end
 end
+
+@testset "copy_to bug" begin
+    model = MOI.Utilities.Model{Float64}()
+    x = MOI.add_variable(model)
+    con = [
+        MOI.add_constraint(
+            model,
+            MOI.ScalarAffineFunction([MOI.ScalarAffineTerm(1.0, x)], 0.0),
+            MOI.EqualTo(1.0),
+        )
+        for i = 1:2
+    ]
+    clp = Clp.Optimizer()
+    index_map = MOI.copy_to(clp, model)
+    @test index_map[con[1]] != index_map[con[2]]
+end